Better Logging When Using Head Sync #7626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7626 +/- ##
==========================================
+ Coverage 61.85% 61.87% +0.01%
==========================================
Files 422 422
Lines 29700 29723 +23
==========================================
+ Hits 18370 18390 +20
- Misses 8412 8416 +4
+ Partials 2918 2917 -1 |
| @@ -431,6 +431,12 @@ func (s *Service) initializeChainInfo(ctx context.Context) error { | |||
| if err != nil { | |||
| return errors.Wrap(err, "could not hash head block") | |||
| } | |||
| finalizedState, err := s.stateGen.Resume(ctx) | |||
There was a problem hiding this comment.
Is there a bug that caused by not running s.stateGen.Resume here?
If yes, can you please add some descriptions for the bug? and maybe a regression test?
There was a problem hiding this comment.
There is no bug, the finalized state is accessed for info purposes.
There was a problem hiding this comment.
Ah not really I just saw that we resumed stategen in the normal path, so I thought it would be correct to do it here too. I used the archived state to determine the starting point of our head sync.
prestonvanloon
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Logging
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N.A
Other notes for review