Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highest slashing attestation RPC endpoint #7647

Merged
merged 10 commits into from
Nov 22, 2020
Merged

highest slashing attestation RPC endpoint #7647

merged 10 commits into from
Nov 22, 2020

Conversation

alonmuroch
Copy link
Contributor

As a followup to the recently merged Highest attestation PR(#7604 ), this PR is just adding an RPC endpoint to consume the data.

@stale
Copy link

stale bot commented Nov 5, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale There hasn't been any activity here in some time... label Nov 5, 2020
@alonmuroch
Copy link
Contributor Author

@shayzluf could you take a look?

@shayzluf
Copy link
Contributor

shayzluf commented Nov 5, 2020

@alonmuroch tests are still failing does not implement ethereum_slashing.SlasherClient (missing...

@alonmuroch
Copy link
Contributor Author

@shayzluf on it

@alonmuroch
Copy link
Contributor Author

@shayzluf all checks pass

@shayzluf shayzluf added Ready For Review A pull request ready for code review and removed Stale There hasn't been any activity here in some time... labels Nov 15, 2020
slasher/rpc/server.go Outdated Show resolved Hide resolved
alonmuroch and others added 4 commits November 17, 2020 11:34
Co-authored-by: Shay Zluf <thezluf@gmail.com>
…to highest_att_api

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
slasher/rpc/server.go Outdated Show resolved Hide resolved
slasher/rpc/server.go Show resolved Hide resolved
slasher/rpc/server.go Show resolved Hide resolved
@prestonvanloon
Copy link
Member

@alonmuroch we don't have permission to push to your branch and all PRs must be synced with the latest master. Please update with master.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 98557e8 into prysmaticlabs:master Nov 22, 2020
@alonmuroch
Copy link
Contributor Author

@prestonvanloon done and it seems to be merged automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants