Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Standard Slashing Protection JSON With Importing Logic #7675

Merged
merged 75 commits into from
Nov 17, 2020

Conversation

shayzluf
Copy link
Contributor

@shayzluf shayzluf commented Oct 29, 2020

Part of #7813

What type of PR is this?

Feature

We have written up a design document for this feature here.

What does this PR do? Why is it needed?

This PR implements the standard slashing interchange format defined by https://eips.ethereum.org/EIPS/eip-3076. It allows for unmarshaling an input JSON file and converting it into our internal representation of attester and proposal slashing protection. Then, we can import this representation into our database atomically.

Among the features included are:

Other notes for review

The underlying representation of proposal protection assumes that everything imported from the JSON will have a signing root, however, signing roots are optional in the EIP. The tracking issue mentions this as an open action item to tackle in a future PR.

@shayzluf shayzluf requested a review from a team as a code owner October 29, 2020 14:27
@shayzluf shayzluf marked this pull request as draft October 29, 2020 14:27
@rauljordan rauljordan dismissed a stale review via a8b9a5b November 17, 2020 15:33
@prylabs-bulldozer prylabs-bulldozer bot merged commit acb47f2 into master Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the import_interchange_json branch November 17, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical Highest, immediate priority item Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants