Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Non Finalized States #7742

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Keep Non Finalized States #7742

merged 2 commits into from
Nov 7, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 7, 2020

What type of PR is this?

State Management

What does this PR do? Why is it needed?

  • Keeps non finalized states rather than also inadvertently deleting them.

Which issues(s) does this PR fix?

Follows on from #7729 .

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 7, 2020 05:49
@nisdas nisdas added the Ready For Review A pull request ready for code review label Nov 7, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 8cac198 into master Nov 7, 2020
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #7742 (b7194bf) into master (4dcae87) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #7742      +/-   ##
==========================================
+ Coverage   62.15%   62.17%   +0.01%     
==========================================
  Files         429      429              
  Lines       30202    30206       +4     
==========================================
+ Hits        18773    18781       +8     
+ Misses       8517     8510       -7     
- Partials     2912     2915       +3     

@delete-merged-branch delete-merged-branch bot deleted the keepNonFinalizedStates branch November 7, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants