Add more validation to AllValidatorsAreExited #7755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
I think this method, which defaults to "true", can be error prone.
I have added a few checks:
Which issues(s) does this PR fix?
Related: #7707
Other notes for review
I did not test at runtime.
This method is used here:
prysm/validator/client/runner.go
Lines 100 to 107 in 3485f3b
In the event, that there is some erroneous failure, it will only log a message rather than stopping the active validators from performing work.