Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blst Build For OSX #7760

Merged
merged 5 commits into from
Nov 10, 2020
Merged

Fix Blst Build For OSX #7760

merged 5 commits into from
Nov 10, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 10, 2020

What type of PR is this?

Feature Addition

What does this PR do? Why is it needed?

  • With the upgrading of our crosstool toolchain, we can now build mac for blst. This PR enables blst for osx machines.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 10, 2020 11:10
@nisdas nisdas added the Ready For Review A pull request ready for code review label Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #7760 (2e8d1b6) into master (d4c9546) will decrease coverage by 0.03%.
The diff coverage is 56.79%.

@@            Coverage Diff             @@
##           master    #7760      +/-   ##
==========================================
- Coverage   62.15%   62.12%   -0.04%     
==========================================
  Files         429      429              
  Lines       30248    30296      +48     
==========================================
+ Hits        18802    18821      +19     
- Misses       8521     8541      +20     
- Partials     2925     2934       +9     

Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prylabs-bulldozer prylabs-bulldozer bot merged commit 8638e2c into master Nov 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the fixMacBlst branch November 10, 2020 18:14
@nisdas nisdas mentioned this pull request Nov 13, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants