Remove Recursive Read Lock in Shared/Rand #7776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
OK to merge
Priority: Critical
nisdas
approved these changes
Nov 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #7776 +/- ##
==========================================
+ Coverage 62.19% 62.22% +0.03%
==========================================
Files 429 429
Lines 30368 30366 -2
==========================================
+ Hits 18887 18896 +9
+ Misses 8546 8533 -13
- Partials 2935 2937 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7770 , the PR introduced a recursive read lock in our rand package. This PR fixes it