Add EIP-2333 Conformity Tests #7783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Priority: High
prestonvanloon
approved these changes
Nov 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #7783 +/- ##
=======================================
Coverage 62.22% 62.22%
=======================================
Files 429 429
Lines 30340 30349 +9
=======================================
+ Hits 18880 18886 +6
- Misses 8524 8527 +3
Partials 2936 2936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7763, this PR adds tests for key derivation in EIP-2333 for our derived keymanager in Prysm.
NOTE: A few test cases are skipped due to an error in our derivation dependency here wealdtech/go-eth2-util#2