Immediate Slashing Protection Data Storage #7789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
changed the title
…rysm into imidiate_save_protection
rauljordan
approved these changes
Nov 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #7789 +/- ##
=======================================
Coverage 62.18% 62.19%
=======================================
Files 429 429
Lines 30395 30412 +17
=======================================
+ Hits 18902 18915 +13
- Misses 8551 8554 +3
- Partials 2942 2943 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
In the current validator protection flow protection data is being saved only at the end of the slot leaving an opportunity to lose protection data on power cuts etc.
This pr makes save operation on per public key basis and saves the data after a successful propose attestation operation.
Which issues(s) does this PR fix?
No open issue for it, we believe it resolves #7076