Warn missing protection db #7792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7792 +/- ##
==========================================
- Coverage 62.05% 62.05% -0.01%
==========================================
Files 430 430
Lines 30467 30473 +6
==========================================
+ Hits 18907 18910 +3
- Misses 8617 8622 +5
+ Partials 2943 2941 -2 |
rauljordan
approved these changes
Nov 12, 2020
rauljordan
added
OK to merge
Ready For Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Not having a slashing protection db file (validator.db) is a major issue to keep our users safe. in order to let users know of the situation i have added a warning as a first step to harden slashing protection.
Which issues(s) does this PR fix?
Part of #7791