Remove Outdated Keystore Cryptography #7796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
OK to merge
Ready For Review
prestonvanloon
previously approved these changes
Nov 12, 2020
…rysm into remove-deprecated-crypto
prestonvanloon
approved these changes
Nov 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #7796 +/- ##
==========================================
+ Coverage 62.03% 62.17% +0.14%
==========================================
Files 430 429 -1
Lines 30475 30395 -80
==========================================
- Hits 18905 18898 -7
+ Misses 8628 8554 -74
- Partials 2942 2943 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the Medalla testnet, we checked in an old version of the EIP keystore derivation logic. This PR removes the dependency, thereby breaking really old Medalla wallets, and resolves #7752. This also unskips the tests for the EIP-2333 derivation compliance: https://eips.ethereum.org/EIPS/eip-2333