Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Builds For Blst #7803

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Fix Windows Builds For Blst #7803

merged 6 commits into from
Nov 13, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 13, 2020

What type of PR is this?

Supports Windows builds for BLST

What does this PR do? Why is it needed?

  • Allows Windows users to also run BLST

Thanks @SuburbanDad !

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 13, 2020 06:33
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #7803 (45a4f9e) into master (5fdb916) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7803      +/-   ##
==========================================
- Coverage   62.09%   62.03%   -0.07%     
==========================================
  Files         431      430       -1     
  Lines       30451    30467      +16     
==========================================
- Hits        18909    18900       -9     
- Misses       8601     8625      +24     
- Partials     2941     2942       +1     

Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @SuburbanDad !

@nisdas nisdas added Ready For Review A pull request ready for code review OK to merge labels Nov 13, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 58fcb52 into master Nov 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the fixWindowsBuils branch November 13, 2020 07:17
@nisdas nisdas mentioned this pull request Nov 13, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants