Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: prysm.bat does not recognize AMD processors as 64 bit #7810

Closed
prestonvanloon opened this issue Nov 13, 2020 · 8 comments
Closed

Windows: prysm.bat does not recognize AMD processors as 64 bit #7810

prestonvanloon opened this issue Nov 13, 2020 · 8 comments
Labels
Bug Something isn't working Good First Issue Good for newcomers Help Wanted Extra attention is needed Windows Anything related only to Windows OS

Comments

@prestonvanloon
Copy link
Member

prysm/prysm.bat

Lines 37 to 41 in 075f145

reg Query "HKLM\Hardware\Description\System\CentralProcessor\0" | find /i "x86" > NUL && set WinOS=32BIT || set WinOS=64BIT
if %WinOS%==32BIT (
echo �[31mERROR: prysm is only supported on 64-bit Operating Systems �[0m
exit /b 1
)

unknown (1)

There is no "x86" string for AMD processors such as AMD Ryzen 5 4600H

@prestonvanloon prestonvanloon added Bug Something isn't working Help Wanted Extra attention is needed Good First Issue Good for newcomers labels Nov 13, 2020
@prestonvanloon
Copy link
Member Author

Workaround script can be used here: https://gist.github.com/prestonvanloon/22b39cffb75371fbe3036d054a89a3ed

@prestonvanloon
Copy link
Member Author

cc: @wgknowles

@wgknowles
Copy link
Contributor

On holiday for a week, but here’s some helpful info: https://ss64.com/nt/syntax-64bit.html

@ThothLogos
Copy link

I was just poking around your issues, some possibilities to explore perhaps for whoever jumps on it:

C:\Users\thoth> WMIC ComputerSystem GET SystemType
SystemType
x64-based PC

C:\Users\thoth> WMIC OS GET OSArchitecture
OSArchitecture
64-bit

@nisdas nisdas added the Windows Anything related only to Windows OS label Dec 16, 2020
@ahadda5
Copy link
Contributor

ahadda5 commented Jul 28, 2021

I ran this test by manually changing the registry entry to be AMD64. It worked just fine.

> reg Query "HKLM\Hardware\Description\System\CentralProcessor\0"

HKEY_LOCAL_MACHINE\Hardware\Description\System\CentralProcessor\0
    Component Information    REG_BINARY    00000000000000000000000000000000
    Identifier    REG_SZ    AMD64 Family 23 Model 96 Stepping 1
    Configuration Data    REG_FULL_RESOURCE_DESCRIPTOR    FFFFFFFFFFFFFFFF0000000000000000
    ProcessorNameString    REG_SZ    Intel(R) Core(TM) i7-8705G CPU @ 3.10GHz
    VendorIdentifier    REG_SZ    GenuineIntel
    FeatureSet    REG_DWORD    0x311b3fff
    ~MHz    REG_DWORD    0xc18
    Update Revision    REG_BINARY    00000000DE000000
    Previous Update Revision    REG_BINARY    00000000B4000000
    Update Status    REG_DWORD    0x0
    Platform Specific Field 1    REG_DWORD    0x8
    Platform Specific Field 2    REG_BINARY    00000000

On running the prysm.bat a beacon-chain-v1.4.2-windows-amd64 was downloaded!
cc @prestonvanloon I think its safe to close .

@wgknowles
Copy link
Contributor

The offending line of code is actually searching for the lack of "x86" being present rather then looking for anything related to AMD/Intel 64. The reason the OP was having issues is that the value of "Platform Specific Field1" (which contains the microcode version) started with 0x86. I'm guessing this bug probably resolved itself as microcode updates to Ryzen no longer have 0x86 in the version number?

@ahadda5
Copy link
Contributor

ahadda5 commented Jul 28, 2021

The offending line of code is actually searching for the lack of "x86" being present rather then looking for anything related to AMD/Intel 64. The reason the OP was having issues is that the value of "Platform Specific Field1" (which contains the microcode version) started with 0x86. I'm guessing this bug probably resolved itself as microcode updates to Ryzen no longer have 0x86 in the version number?

Good point. By the way i was manually changing the registry entries(it is an Intel64 in my case) :)
In such a case maybe look in the that field only vs all fields . but yet again one is under the mercy of the vendor/Microsoft updates.

@prestonvanloon
Copy link
Member Author

Closing old issue. Please add a comment if this is still ongoing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good First Issue Good for newcomers Help Wanted Extra attention is needed Windows Anything related only to Windows OS
Projects
None yet
Development

No branches or pull requests

5 participants