Refactor HD Wallets for Enhanced Security #7821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Nov 16, 2020
| @@ -9,7 +9,6 @@ import ( | |||
| "github.com/manifoldco/promptui" | |||
There was a problem hiding this comment.
Review these changes
| @@ -36,7 +36,7 @@ type RecoverWalletConfig struct { | |||
| WalletDir string | |||
There was a problem hiding this comment.
Review these changes
| @@ -6,61 +6,30 @@ import ( | |||
| "fmt" | |||
There was a problem hiding this comment.
Review this file
rauljordan
added
Accounts
Ready For Review
…to secure-hd-wallets
…to secure-hd-wallets
prestonvanloon
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Our current HD wallet is extremely insecure, and other teams do not follow our convention. Currently:
If someone takes this seed, or dumps a validator's memory, they are screwed. Moreover, storing a seed on disk is still not an adequate substitute.
This PR advocates for a different approach to our HD wallet altogether. Instead, we make it a simple wrapper around our imported keymanager. During wallet creation, we now show the user a mnemonic and ask them to write it offline, then we ask the user to generate N accounts where N > 0. Then, we import those as keystore files into our imported keymanager. The seed nor mnemonic are never stored after this.
This PR also removes the
accounts createcommand the RPC endpoint given there is no longer any way to create a new account in Prysm. This must be done by another tool such as ethdo or the deposit cli.