beacon-chain/sync: fix flaky segfault in tests #7822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed this segfault running all tests on mater, occurring in around 2-3 out of 10 test runs. ``` FAIL: //beacon-chain/sync:go_default_test (shard 3 of 4, run 1 of 10) (see /home/j/.cache/bazel/_bazel_j/1ba834ca9d49f27aeb8f0bbb6f28fdf3/execroot/prysm/bazel-out/k8-fastbuild/testlogs/beacon-chain/sync/go_default_test/shard_3_of_4_run_1_of_10/test.log) INFO: From Testing //beacon-chain/sync:go_default_test (shard 3 of 4, run 1 of 10): ==================== Test output for //beacon-chain/sync:go_default_test (shard 3 of 4, run 1 of 10): panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x138eea6] goroutine 1660 [running]: github.com/prysmaticlabs/prysm/shared/abool.(*AtomicBool).IsSet(...) shared/abool/abool.go:39 github.com/prysmaticlabs/prysm/beacon-chain/sync.(*Service).subscribeStaticWithSubnets.func1(0xc002dd4400, 0xc002990940, 0x17bca26, 0x1e) beacon-chain/sync/subscriber.go:207 +0xe6 created by github.com/prysmaticlabs/prysm/beacon-chain/sync.(*Service).subscribeStaticWithSubnets beacon-chain/sync/subscriber.go:200 +0x172 ================================================================================ ``` TestStaticSubnets was testing a Service with an uninitialized chainStarted value. This commit initializes chainStarted explicitly in all tests that construct a Service. This reduces the observed flake rate to 0/10 runs. This was verified with: ``` ./bazel.sh test //beacon-chain/sync:go_default_test --runs_per_test 10 ```
|
|
james-rms
changed the title
rkapka
approved these changes
Nov 16, 2020
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Observed this segfault running all tests on
master, occurringin around 2-3 out of 10 test runs.
TestStaticSubnets was testing a Service with an uninitialized
chainStarted value. This commit initializes chainStarted explicitly
in all tests that construct a Service. This reduces the observed flake
rate to 0/10 runs. This was verified with:
Which issues(s) does this PR fix?
N/A
Other notes for review