Source lrg target #7839
Merged
Source lrg target #7839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Nov 17, 2020
| if (targetEpoch - sourceEpoch) > params.BeaconConfig().WeakSubjectivityPeriod { | ||
| dis := targetEpoch - sourceEpoch | ||
|
|
||
| if sourceEpoch > targetEpoch { //Prevent underflow and handle source > target slashable cases. |
There was a problem hiding this comment.
why flip source and target epoch here ?
There was a problem hiding this comment.
spans are recorded at source epoch. we need to get the right spans for detection to work right
rauljordan
reviewed
Nov 17, 2020
rauljordan
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
What does this PR do? Why is it needed?
Attestation with higher source than target epoch could be potentially found in the network
This pr makes an improvement in handling these edge cases on:
Which issues(s) does this PR fix?
Fixes #7161