Dynamic Reloading of Keys on Any FSNotify Event #7873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
farazdagi,
terencechain,
nisdas and
prestonvanloon
|
Did you confirm that nothing will happen when:
|
terencechain
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Why is it needed?
This PR attempts to reload validating keys from a file in a debounced manner if any fsnotify event is triggered, rather than just writes. The current approach would prevent symbolic links from reloading keys into the validator client. We throw errors if we attempt to reload a bad keystore or a keystore with empty keys.
Which issues(s) does this PR fix?
Fixes #7732