Make TLS connections to a remote wallet non-mandatory #7953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
changed the title
rkapka
commented
Nov 25, 2020
| return nil, errors.Wrapf(err, "could not determine absolute path for %s", crt) | ||
|
|
||
| crtPath, keyPath, caPath := "", "", "" | ||
| if crt != "" { |
There was a problem hiding this comment.
When TLS is disabled, then passing cert paths is optional, and we should validate a path if it's provided. That's why I didn't surround this code with the flag check.
rkapka
added
release-target
and removed
Ready For Review
rkapka
added
Ready For Review
rauljordan
previously approved these changes
Nov 25, 2020
prestonvanloon
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
TLS communication with a remote wallet will no longer be required. It can be configured with the
disable-remote-signer-tlsflag.Which issues(s) does this PR fix?
N/A
Other notes for review
Even though this allows insecure connections, it does not realistically compromise security. For details, please see https://discord.com/channels/476244492043812875/774005284188323870/780838701563379792. Most important part from the linked discussion: