Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Interop Mode #7978

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Fix Interop Mode #7978

merged 4 commits into from
Dec 2, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 27, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Fix interop mode by allowing broadcasts without the requisite number of peers.

Which issues(s) does this PR fix?

Fixes #7673

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 27, 2020 15:09
@nisdas nisdas added the Ready For Review A pull request ready for code review label Nov 27, 2020
@nisdas nisdas added this to the v1.1.0 milestone Nov 27, 2020
@nisdas nisdas changed the base branch from master to v1.1.0 November 27, 2020 15:10
@nisdas nisdas changed the base branch from v1.1.0 to master November 27, 2020 15:10
@@ -53,7 +54,7 @@ func (s *Service) PublishToTopic(ctx context.Context, topic string, data []byte,

// Wait for at least 1 peer to be available to receive the published message.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this command for the second condition?

@rauljordan rauljordan changed the base branch from master to develop November 30, 2020 21:39
@rkapka rkapka modified the milestones: v1.0.3, v1.1.0 Dec 2, 2020
@ibrahim419

This comment was marked as spam.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 20514cd into develop Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the fixInterop2 branch December 2, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interop testnet's beacon node can't find peers in beta.0
6 participants