Log with field error instead of err #7998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Nov 30, 2020
prestonvanloon
requested changes
Nov 30, 2020
Oh but I didn't write any of it just batch changed "err" for "error". Sure, your changes are perfect! |
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
prestonvanloon
previously approved these changes
Nov 30, 2020
rauljordan
dismissed
prestonvanloon’s stale review
The base branch was changed.
terencechain
added
Ready For Review
terencechain
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Small enhancement
What does this PR do? Why is it needed?
It changes the field logged in some initial sync warnings from "err" to "error", this reduces slightly the footprint on the journal and simplifies a bit log-parsing scripts.
Which issues(s) does this PR fix?
None filed.