Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging with PadLevelText to true #8003

Merged
merged 6 commits into from
Dec 2, 2020
Merged

Logging with PadLevelText to true #8003

merged 6 commits into from
Dec 2, 2020

Conversation

terencechain
Copy link
Member

What type of PR is this?

Feature

What does this PR do? Why is it needed?
Set PadLevelText to true for logging. Before and after:

Screen Shot 2020-11-30 at 8 44 51 AM
Screen Shot 2020-11-30 at 8 58 19 AM

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@terencechain terencechain requested a review from a team as a code owner November 30, 2020 17:28
rkapka
rkapka previously approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we stick to green or is the color non-editable?

@terencechain terencechain added Discussion Simply a thread for talking about stuff Blocked Blocked by research or external factors labels Nov 30, 2020
@terencechain
Copy link
Member Author

Can we stick to green or is the color non-editable?

Non editable unless we fork logrus and do it ourself. There's probably other forks that do it, I didnt spend too much time.

Also marked this as blocked and discussion to get more soak time for feedbacks

@rauljordan rauljordan changed the base branch from master to develop November 30, 2020 21:31
@rauljordan rauljordan dismissed rkapka’s stale review November 30, 2020 21:31

The base branch was changed.

@prestonvanloon prestonvanloon marked this pull request as draft December 2, 2020 20:12
@terencechain terencechain marked this pull request as ready for review December 2, 2020 23:19
@terencechain terencechain added Ready For Review A pull request ready for code review and removed Blocked Blocked by research or external factors labels Dec 2, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit c51754f into develop Dec 2, 2020
@terencechain terencechain removed the Discussion Simply a thread for talking about stuff label Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the log-with-padding branch December 2, 2020 23:49
terencechain added a commit that referenced this pull request Dec 3, 2020
@terencechain
Revert "Logging with PadLevelText to true (#8003)"
323e48a 
This reverts commit c51754f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@rkapka rkapka rkapka left review comments

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@nisdas nisdas Awaiting requested review from nisdas

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terencechain @rauljordan @rkapka