Update attestation schedule log with total attester count #8013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
reviewed
Dec 1, 2020
validator/client/validator.go
Outdated
| log.WithField("slot", slotOffset+i).WithField("attesters", len(attesterKeys[i])).WithField("pubKeys", attesterKeys[i]).Info("Attestation schedule") | ||
| log.WithFields(logrus.Fields{ | ||
| "slot": slotOffset + i, | ||
| "attesters": strconv.FormatInt(int64(len(attesterKeys[i])), 10) + "/" + total, |
There was a problem hiding this comment.
why not fmt? seems simpler
…s/prysm into better-attested-log
terencechain
force-pushed
the
better-attested-log
branch
from
9ea6e73
to
a0b954f
Compare
rauljordan
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Attestation schedule log was confusing. Instead of
"attesters":$SLOT_COUNT, this PR changes it to"attesters":$SLOT_COUNT/$TOTAL_COUNTcc: @emansipater