Revert "Logging with PadLevelText to true"
#8036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c51754f.
farazdagi
previously approved these changes
Dec 3, 2020
farazdagi
force-pushed
the
revert-8003-log-with-padding
branch
from
466f483
to
323e48a
Compare
farazdagi
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received late feedbacks from 2 that preferred the old format. The color and prefix placements were the main concerns. Given these late feedbacks, we were not at unanimous decision as we once thought. Reverting for the time being and exploring better alternates that will satisfy the both worlds