Remove custom block body root and block root methods #8069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
previously approved these changes
Dec 7, 2020
nisdas
previously approved these changes
Dec 8, 2020
|
@terencechain tests fail |
…prysm into remove-block-root-methods
|
Fails to build @terencechain |
rauljordan
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
To eliminate discrepancy of having two different ways to hash root root block body and block. This PR removes our custom
BlockRootandBlockBodyRoot. They were mostly used for tests and benchmarks and migrations. Migration should have used fast ssz instead.Which issues(s) does this PR fix?
Fixes # N/A
Other notes for review
N/A