Testutil: Can generate attestation at epoch boundary #8265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Fixes a bug in
GenerateAttestationsin pkgtestutil.GenerateAttestationsworks by decreasing input slot (n) by 1 (n-1), this ensures computed attestation has the on time property for the current slot. ThecurrentEpochwhich is used to calculate target root should respect the (n-1) property, or else at the epoch boundary slot we will be getting epoch out of bound. (ex: input slot 32, attestation slot 31, the epoch suppose to be 0 but it's 1)Which issues(s) does this PR fix?
No issue. Discovered while writing blockchain unit tests.
Other notes for review
Only touches test code