Add canonical flag to ListBlocks API response #8287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinglamb
force-pushed
the
feature-add-canonical-to-blocks-api
branch
2 times, most recently
from
49ef829
to
f851bb1
Compare
|
@rkapka I updated the |
Codecov Report
@@ Coverage Diff @@
## develop #8287 +/- ##
==========================================
Coverage ? 57.01%
==========================================
Files ? 448
Lines ? 31348
Branches ? 0
==========================================
Hits ? 17874
Misses ? 10688
Partials ? 2786 |
|
This PR should be merged after #8288 |
pinglamb
force-pushed
the
feature-add-canonical-to-blocks-api
branch
from
229de91
to
d5d8428
Compare
prestonvanloon
previously approved these changes
Jan 19, 2021
|
Hi @pinglamb looks like some conflicts in go.mod, should be easy to fix but will likely require you to run go mod tidy afterwards |
pinglamb
force-pushed
the
feature-add-canonical-to-blocks-api
branch
3 times, most recently
from
f3dada5
to
8607398
Compare
rauljordan
previously approved these changes
Jan 25, 2021
rauljordan
added
OK to merge
Ready For Review
|
Some conflicts @pinglamb |
pinglamb
force-pushed
the
feature-add-canonical-to-blocks-api
branch
from
b04a994
to
d9e9589
Compare
|
@rauljordan The |
terencechain
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Adding
canonicalflag to/eth/v1alpha1/beacon/blocksso client can identify if the block is orphaned.Which issues(s) does this PR fix?
Fixes #8064
Other notes for review