Add Custom Deadline for Slot Progression #8388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Feb 3, 2021
prestonvanloon
requested changes
Feb 3, 2021
| @@ -104,6 +108,9 @@ func (s *Service) onBlock(ctx context.Context, signed *ethpb.SignedBeaconBlock, | |||
| // Updating next slot state cache can happen in the background. It shouldn't block rest of the process. | |||
| if featureconfig.Get().EnableNextSlotStateCache { | |||
| go func() { | |||
| // Use a custom deadline here, since this method runs asynchronously. | |||
| ctx, cancel := context.WithTimeout(context.Background(), slotDeadline) | |||
There was a problem hiding this comment.
Why does this use context.Background() instead of the parent context?
There was a problem hiding this comment.
Oh, I see in the PR description. Could you please add more information in the code commentary please?
prestonvanloon
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
when updating the cache, as the context used can be canceled prematurely before the state has had a chance to
advance. This instead uses a custom deadline so that it doesn't exit prematurely.
Which issues(s) does this PR fix?
N.A
Other notes for review