Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up state pkg's getter and setter #8533

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

terencechain
Copy link
Member

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?
Before we use interface for state pkg's getter and setter, I want to do one round of clean up. Changes:

  • HasInnerState() can be private hasInnerState()
  • Getter's GenesisUnixTime and ParentRoot are not used. They dont seem to have much use cases so deleting them
  • Setter's SetValidatorIndexByPubkey is not used. Deleting it
  • Validator read only getter's CopyValidator() is not used. Deleting it
  • Move validator read only getter's to validator_getter.go to stay lean

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@terencechain terencechain added Ready For Review A pull request ready for code review Cleanup Code health! labels Mar 2, 2021
@terencechain terencechain self-assigned this Mar 2, 2021
@terencechain terencechain requested a review from a team as a code owner March 2, 2021 01:46
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@46f6bd6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #8533   +/-   ##
==========================================
  Coverage           ?   58.11%           
==========================================
  Files              ?      462           
  Lines              ?    33167           
  Branches           ?        0           
==========================================
  Hits               ?    19275           
  Misses             ?    10967           
  Partials           ?     2925           

@prylabs-bulldozer prylabs-bulldozer bot merged commit 4c49d4a into develop Mar 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the beacon-state-cleanups branch March 2, 2021 12:37
@terencechain terencechain mentioned this pull request Mar 21, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants