Beacon state: Add interfaces #8544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
reviewed
Mar 2, 2021
| } | ||
|
|
||
| // ReadOnlyBeaconState defines a struct which only has read access to beacon state methods. | ||
| type ReadOnlyBeaconState interface { |
There was a problem hiding this comment.
We should move the state ifaces to the top of the file to make them easier to find
rauljordan
previously approved these changes
Mar 2, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8544 +/- ##
==========================================
Coverage ? 58.26%
==========================================
Files ? 462
Lines ? 33072
Branches ? 0
==========================================
Hits ? 19268
Misses ? 10875
Partials ? 2929 |
rauljordan
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
As in preparation for revamping state usages for hardfork, this PR implements the interfaces around
statepkg getters and setters. The interfaces are broken down by major functionality as well as read only and write only.One caveat is I had to use
iface.ReadOnlyValidatorright away to satisfyvar _ iface.BeaconState = (*BeaconState)(nil). The changes for that isn't bad. I hope we don't mind squeezing it in the same PR.The follow up PRs will be using these interfaces
Which issues(s) does this PR fix?
N/A
Other notes for review
Tested run time