Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DeepSSZEqual for beacon state object compare #8557

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Use DeepSSZEqual for beacon state object compare #8557

merged 2 commits into from
Mar 4, 2021

Conversation

terencechain
Copy link
Member

What type of PR is this?

Test

What does this PR do? Why is it needed?

Replace .DeepEqual with .DeepSSZEqual for beacon state object compare

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@terencechain terencechain added the Ready For Review A pull request ready for code review label Mar 4, 2021
@terencechain terencechain self-assigned this Mar 4, 2021
@terencechain terencechain requested a review from a team as a code owner March 4, 2021 15:02
@rauljordan rauljordan merged commit c1d4ff6 into develop Mar 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the use-deep-ssz1 branch March 4, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@rkapka rkapka Awaiting requested review from rkapka

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terencechain @rauljordan