Interface Analyzer #8923
Merged
Interface Analyzer #8923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you add a new check instead of replacing the existing one? After all |
|
@rkapka because the interface itself could be nil, so running any receiver methods would create a panic |
Codecov Report
@@ Coverage Diff @@
## develop #8923 +/- ##
===========================================
- Coverage 60.89% 60.87% -0.02%
===========================================
Files 528 528
Lines 37336 37337 +1
===========================================
- Hits 22735 22729 -6
Misses 11344 11344
- Partials 3257 3264 +7 |
| } | ||
| if xIsIface && yIsNil { | ||
| pass.Reportf(identX.Pos(), "A nilness check is being performed on an interface"+ | ||
| ", this check needs another accompanying check on the underlying object for the interface") |
There was a problem hiding this comment.
Little confusing. What does "another accompanying check" mean? Better to be specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
equality checks are being compared.
Which issues(s) does this PR fix?
N.A
Other notes for review