Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated function usages #8953

Merged
merged 3 commits into from May 28, 2021
Merged

Update deprecated function usages #8953

merged 3 commits into from May 28, 2021

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented May 28, 2021

What type of PR is this?
Cleanup

What does this PR do? Why is it needed?
Fixes #6891

This PR goes through the deprecated usages mention in #6891 on top of me looking through with inspect code and changing any function usages that made sense to update.

@0xKiwi 0xKiwi requested a review from a team as a code owner May 28, 2021 00:33
@0xKiwi 0xKiwi added the Ready For Review A pull request ready for code review label May 28, 2021
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #8953 (e36c979) into develop (6bb3cc4) will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #8953      +/-   ##
===========================================
+ Coverage    60.89%   60.91%   +0.02%     
===========================================
  Files          530      530              
  Lines        37501    37501              
===========================================
+ Hits         22835    22845      +10     
+ Misses       11387    11376      -11     
- Partials      3279     3280       +1     

@rkapka rkapka merged commit 40b4079 into develop May 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the clear-deprecated branch May 28, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing deprecated packages and members
3 participants