Naive aggregation for SyncCommitteeContribution
#9114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested review from
kasey,
jmozah and
prestonvanloon
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #9114 +/- ##
===========================================
+ Coverage 60.25% 60.29% +0.04%
===========================================
Files 544 546 +2
Lines 38755 38819 +64
===========================================
+ Hits 23350 23407 +57
+ Misses 12045 12043 -2
- Partials 3360 3369 +9 |
nisdas
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add naive aggregation for
SyncCommitteeContributionobject (Altair)max-cover aggregation is a
todo, it will be tackled later