Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove empty directories not present in metadata (-E, --remove-empty-dirs) #10

Closed
przemoc opened this issue Mar 2, 2014 · 3 comments
Milestone

Comments

@przemoc
Copy link
Owner

przemoc commented Mar 2, 2014

No description provided.

@dfandrich
Copy link
Contributor

I agree this option is needed. But the -e option is clearly marked "experimental", so reusing that option (instead of -E) for this when combined with --apply, is a natural enhancement. I don't think a new option is warranted.

@przemoc
Copy link
Owner Author

przemoc commented Nov 24, 2014

It's true that you can read in -e option description:

This is currently an experimental feature.

But it's in such state for at least few years already, so I believe that changing such behavior now would be detrimental. Behavior breaking should be avoided if possible, especially by tools used in batch scripts. Let's give people ways to improve what they do, but let's not enforce it, because we not necessarily always know better.

In your case removing empty directories is maybe natural, but for someone else - not. That said, introducing config file (#7) will surely help users tune metastore settings to their own needs (if defaults don't meet their needs).

Thus I am against expanding -e meaning to cover removing empty directories too.

@przemoc
Copy link
Owner Author

przemoc commented Sep 2, 2015

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants