refactor: tweak style

lib/downloader.js

@@ -16,7 +16,8 @@ const isWin = flags.includes('--platform=windows') || require('./util').isWin
 const isOverwrite = flags.includes('--overwrite')
 
 // First, look for the download link.
-let dir, filePath
+let dir
+let filePath
 const defaultBin = path.join(__dirname, '..', 'bin')
 
 function download (url, callback) {
@@ -74,13 +75,13 @@ function downloader (binDir, callback) {
   // handle overwritin
   if (fs.existsSync(filePath)) {
     if (!isOverwrite) {
-      return callback('File exists')
-    } else {
-      try {
-        fs.unlinkSync(filePath)
-      } catch (e) {
-        callback(e)
-      }
+      return callback(new Error('File exists'))
+    }
+
+    try {
+      fs.unlinkSync(filePath)
+    } catch (e) {
+      callback(e)
     }
   }
 

lib/youtube-dl.js

@@ -21,9 +21,15 @@ let ytdlBinary = null
 const execa = universalify.fromPromise(require('execa'))
 
 function youtubeDl (args, options, cb) {
-  return execa(ytdl.getYtdlBinary(), args, options, function done (err, output) {
+  return execa(ytdl.getYtdlBinary(), args, options, function done (
+    err,
+    output
+  ) {
     if (err) return cb(err)
-    return cb(null, output.stdout ? output.stdout.trim().split(/\r?\n/) : undefined)
+    return cb(
+      null,
+      output.stdout ? output.stdout.trim().split(/\r?\n/) : undefined
+    )
   })
 }
 
@@ -208,7 +214,9 @@ ytdl.setYtdlBinary = function setYtdlBinary (path) {
  * @param {String} path
  */
 ytdl.getYtdlBinary = function getYtdlBinary () {
-  return ytdlBinary ? ytdlBinary : path.resolve(__dirname, '..', 'bin', 'youtube-dl')
+  return ytdlBinary
+    ? ytdlBinary
+    : path.resolve(__dirname, '..', 'bin', 'youtube-dl')
 }
 
 /**

scripts/download.js

@@ -1,7 +1,3 @@
-var downloader = require('../lib/downloader')
-
-downloader().then((message) => {
-  console.log(message);
-}).catch((err) => {
-  console.error(err)
-});
+require('../lib/downloader')()
+  .then(message => console.log(message))
+  .catch(err => console.error(err.message || err))