You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We're migrating fzaninotto/faker to fakerphp/faker but the orchestra/testbench makes it impossible to use it, failing on dependency resolution.
psalm/plugin-laravel is already a dev dependency on our project.
Describe the solution you'd like
Move orchestra/testbench to require-dev
Describe alternatives you've considered
I do not seed a reason to make it a normal require on package.
The text was updated successfully, but these errors were encountered:
As I see, ApplicationHelper uses Orchestra\Testbench\Concerns\CreatesApplication so moving can cause errors when not requiring orchestra/testbench on projects.
orchestra/testbench is currently a dependency for support of packages. Developers who create third party laravel packages need to be able to run static analysis, but they don't necessarily have an app to boot up. Testbench currently provides us one that we can easily use in those scenarios.
When doing your update, make sure to --with-all-dependencies to try updating the packages dependencies as well
Alternatively, maybe orchestra/testbench can be changed to orchestral/testbench-core. If this is all that it needs we can avoid loading unnecessary dependencies as it is pointed at orchestral/testbench#301 (reply in thread)
Is your feature request related to a problem? Please describe.
We're migrating
fzaninotto/faker
tofakerphp/faker
but theorchestra/testbench
makes it impossible to use it, failing on dependency resolution.psalm/plugin-laravel
is already a dev dependency on our project.Describe the solution you'd like
Move
orchestra/testbench
torequire-dev
Describe alternatives you've considered
I do not seed a reason to make it a normal require on package.
The text was updated successfully, but these errors were encountered: