Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why orchestra/testbench isn't a require-dev? #130

Closed
stephandesouza opened this issue Mar 10, 2021 · 3 comments
Closed

Why orchestra/testbench isn't a require-dev? #130

stephandesouza opened this issue Mar 10, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@stephandesouza
Copy link

Is your feature request related to a problem? Please describe.
We're migrating fzaninotto/faker to fakerphp/faker but the orchestra/testbench makes it impossible to use it, failing on dependency resolution.

psalm/plugin-laravel is already a dev dependency on our project.

image

Describe the solution you'd like
Move orchestra/testbench to require-dev

Describe alternatives you've considered
I do not seed a reason to make it a normal require on package.

@stephandesouza stephandesouza added the enhancement New feature or request label Mar 10, 2021
@stephandesouza
Copy link
Author

Dang!

As I see, ApplicationHelper uses Orchestra\Testbench\Concerns\CreatesApplication so moving can cause errors when not requiring orchestra/testbench on projects.

@mr-feek
Copy link
Collaborator

mr-feek commented Mar 18, 2021

Hey @stephandesouza !

orchestra/testbench is currently a dependency for support of packages. Developers who create third party laravel packages need to be able to run static analysis, but they don't necessarily have an app to boot up. Testbench currently provides us one that we can easily use in those scenarios.

When doing your update, make sure to --with-all-dependencies to try updating the packages dependencies as well

@mr-feek mr-feek closed this as completed Mar 18, 2021
@dionysiosarvanitis
Copy link

Alternatively, maybe orchestra/testbench can be changed to orchestral/testbench-core. If this is all that it needs we can avoid loading unnecessary dependencies as it is pointed at orchestral/testbench#301 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants