Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using psalm phar archive as language server #33

Closed
thbley opened this issue Feb 6, 2021 · 2 comments
Closed

Support for using psalm phar archive as language server #33

thbley opened this issue Feb 6, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@thbley
Copy link

thbley commented Feb 6, 2021

I've tried to set psalm.psalmScriptPath to the location of the psalm 4.4.1 phar file. This did not work (psalm started regular check instead of language-server).
Version psalm-vscode-plugin 1.2.2
Vs-code 1.52.1

Using psalm as a composer library worked as expected.

There seems to be a fix in current master branch, so I compiled the extension from current master and loaded this in vs-code.
Language-server starts as expected when setting psalm.psalmScriptPath to the phar file.
But when I make changes to a php file, the issues that psalm finds are not updated.
When I restart the language-server manually, the issues get updated.

@thbley
Copy link
Author

thbley commented Aug 3, 2021

Using the psalm phar archive works now using workspace relative paths in the settings.

Tested with:
php 8.0.9
psalm 4.9.1 (phar)
vscode 1.58.2
vscode extension v2.0.5

Thanks!

@thbley
Copy link
Author

thbley commented Aug 14, 2021

But when I make changes to a php file, the issues that psalm finds are not updated.

vimeo/psalm#6301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants