-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering Peaks by multiple properties #8
Comments
At the moment, the Peak class only allows filtering by one metric at a time. |
This functionality has been added in commit f6e0abb The process to do this as of now is as follows:
The output peaks can now be passed into the <filterByProperty()> functions alongside the arguments. This will be released as PATCH release - v0.5.1 accounting for the fact that this is an essential feature for Peak FilteringThe pipelining of filtering properties will be added in next release. (v0.6.0) |
Update to filtering method in v0.5.1With the addition of the feature of filtering from a specific list of peaks, some new updates have also been made in the way the functions are called. Unlike before, filtering for a lower or upper threshold does not require passing "lower" or "upper" as argument. In stead you can now pass null. All the So, code from #8 (comment) will now be written as follows:
|
Awesome. Cheers! I'll have a look. |
Is there a way to filter peaks by multiple properties (as done in scipy)?
Example in scipy:
jDSP currently allows filtering by only one metric (i.e. find* methods return int[], and they cannot be filtered further). Unless I'm missing something
The text was updated successfully, but these errors were encountered: