Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port on/off command bits #26

Closed
ThirteenFish opened this issue Mar 12, 2014 · 1 comment
Closed

Fix port on/off command bits #26

ThirteenFish opened this issue Mar 12, 2014 · 1 comment

Comments

@ThirteenFish
Copy link
Member

They are currently implemented as a bit field where bit 1 corresponds to port 1, and so on. As a result we have no way to set port 8, but at current this is OK because port 8 is non-functional in hardware. It may not be in the distant future though.

To fix this bit 0 should correspond to port 1, ... bit 7 to port 8. This change needs to be made at the same time as the change in the RNH page in fc-test

@ThirteenFish
Copy link
Member Author

fixed in 89ffc2f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant