Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to short-circuit calls with concrete arguments #190

Open
pschanely opened this issue Nov 23, 2022 · 0 comments
Open

Do not attempt to short-circuit calls with concrete arguments #190

pschanely opened this issue Nov 23, 2022 · 0 comments

Comments

@pschanely
Copy link
Owner

Noted by @petrusboniatus in #187 (reply in thread)_

One thing that came as a shock to me is that without precomputing the hash outside the function it does not end ...

If you make many calls (in this case ~30) to short-circuit-able functions like hash(), is likely that at least one of them will short-circuit. But we want at least some number of executions to avoid them all (and probably some to use them all). But in this case, it's especially sad because all the arguments are concrete. At the very least, we should never short-circuit when given concrete arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant