Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severe bug when using sunshine duration as input #65

Closed
pschmidtwalter opened this issue Dec 1, 2022 · 1 comment
Closed

Severe bug when using sunshine duration as input #65

pschmidtwalter opened this issue Dec 1, 2022 · 1 comment

Comments

@pschmidtwalter
Copy link
Owner

There is a bad issue with the function calc_globrad() that was discovered when running a longer simulation. In run_LWFB90(), calc_globrad() derives global radiation from sunshine duration hours when it is called with options_b90$fornetrad = 'sunhours'.

The bug was discovered from suspicious annual sums of potential transpiration (output$ptran):

image

Global radiation, as calculated from sunshine duration hour using calc_globrad() caused this weird course of potential transpiration, it seems an annual course of global radiation is somehow projected to entire timeseries:

image

I will fix this as soon as possible, and try to find out in what cases simulations are concerned.

@pschmidtwalter
Copy link
Owner Author

When merging data.frames of extraterrestrial radiation with sunshine duration hours, ordering by date chained to the merge() had no effect. So, the timeseries was ordered by day-of-year, explaining the suspicious course of global radiation seen above. The bug concerns basicly all simulations that used sunshine duration hours as input. Now this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant