Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving decrypt/decode functionality #13

Open
brendo opened this issue Nov 17, 2014 · 1 comment
Open

Improving decrypt/decode functionality #13

brendo opened this issue Nov 17, 2014 · 1 comment

Comments

@brendo
Copy link

brendo commented Nov 17, 2014

I really like the setup of this library and I believe it works quite well for the creation of a JWT. However I think there's room to improve on the decode/decrypt side of the fence.

Ideally it'd be great to deal with the ClaimCollection or Claim objects, especially for validating each claim is correct. At the minute, there is logic inside of the verify function for some claims. What if this logic sat on the Claim itself and Jwt simply asked the ClaimsCollection to find out if the token claims were correct?

@enygma
Copy link
Member

enygma commented Nov 17, 2014

Hmm, I'm not sure that kind of logic belongs in a collection class...maybe another Verify kind of class that the claims could be passed into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants