Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check correctness of face insertion for simplicial complexes #12

Closed
Pseudomanifold opened this issue Feb 15, 2017 · 0 comments
Closed
Assignees
Labels

Comments

@Pseudomanifold
Copy link
Owner

The simplicial complex class automatically inserts faces of the simplices in order to retain validity. Maybe this is not the smartest move because one might want to check in a partial list of simplices without creating their faces.

Need to check at which points this may cause a problem.

@Pseudomanifold Pseudomanifold self-assigned this Feb 15, 2017
Pseudomanifold added a commit that referenced this issue Apr 11, 2017
Since I want to remove the automated creation of new faces in simplicial
complexes, as referenced in issue #12, I need to specify *all* the faces
of the simplicial complex here.
Pseudomanifold added a commit that referenced this issue Apr 11, 2017
In some cases, this may cause problems, but the present behaviour is
more true to the way the complex should be created. I could even add
a functor for the 'face creation phase' of the simplicial complex in
order to give clients more flexibility when choosing weights.

This solves issue #12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant