Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate performance issues of bipartite adjacency matrix reader class #41

Closed
Pseudomanifold opened this issue Feb 23, 2018 · 2 comments
Closed

Investigate performance issues of bipartite adjacency matrix reader class #41

Pseudomanifold opened this issue Feb 23, 2018 · 2 comments

Comments

@Pseudomanifold
Copy link
Owner

The class is really slow, even for small graphs with less than 1000 nodes. Need to do a proper profiling run here.
@Pseudomanifold
Copy link
Owner Author

Potential culprit: split() and trim() operations. There are a lot of strings created there.

Pseudomanifold added a commit that referenced this issue Mar 1, 2018
@Pseudomanifold
Rewrote bipartite adjacency matrix reader to count tokens
904a53a 
This is in response to issue #41, which concerns performance issues that
occur upon parsing. Trying to alleviate this. The current implementation
already reduces time from ~2s to ~0.76s for a test run (20 matrices).
Pseudomanifold added a commit that referenced this issue Mar 1, 2018
@Pseudomanifold
Simplified value extraction for bipartite adjacency matrices
01e84b3 
Again, this is related to issue #41. Instead of taking into account all
the tokens per line, I am calculating width and height afterwards using
a *single sweep*.
@Pseudomanifold
Copy link
Owner Author

Fixed. While performance can be improved even more, the class does not have any obvious deficiencies any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pseudomanifold