Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HDF5 usage (make optional/configurable) #49

Closed
Pseudomanifold opened this issue May 2, 2018 · 1 comment
Closed

Fix HDF5 usage (make optional/configurable) #49

Pseudomanifold opened this issue May 2, 2018 · 1 comment
Assignees
@Pseudomanifold
Labels
enhancement

Comments

@Pseudomanifold
Copy link
Owner

It makes sense to keep HDF5 configurable for users because they do not necessarily want to use the library just for obtaining a corresponding simplicial complex reader.

Ideally, we should do the following:

  • Check for HDF5
  • Set a provisional HDF5_FOUND variable
  • Make it configurable by users

Alternatively, we could try to detect proper installations by attempting to compile a snippet. It might be possible to use CHECK_CXX_SOURCE_COMPILES for this purpose.
@Pseudomanifold Pseudomanifold self-assigned this May 2, 2018
Pseudomanifold added a commit that referenced this issue May 27, 2018
@Pseudomanifold
Improved HDF5 support
3c10c00 
This goes towards solving issue #49. There is not yet a fully-automated
check in place for checking whether HDF5 can be used correctly, but the
cache variable may now be toggled.
@Pseudomanifold
Copy link
Owner Author

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pseudomanifold Pseudomanifold

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pseudomanifold