Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBB causes the image to load twice #72

Closed
fireattack opened this issue Mar 24, 2017 · 3 comments
Closed

BBB causes the image to load twice #72

fireattack opened this issue Mar 24, 2017 · 3 comments

Comments

@fireattack
Copy link

fireattack commented Mar 24, 2017

This is a problem I encountered only recently.

All default settings, tested in clean profile of Firefox and Chrome.

To repro:

  1. open any post link, like http://danbooru.donmai.us/posts/2648611
  2. You can clearly notice the image is loaded twice by flashing.

It can be seen in the network tool as well:

image

Notice that they have slightly different URLs (albeit the same image).

Disabling BBB immediately fixed the problem.

@ghost
Copy link

ghost commented Mar 25, 2017

I suppose the real problem is the change in Danbooru's file names. The script has been rebuilding the post content for quite a long time in order to keep things simple. Backup your settings and try out the current work in progress from the other branch. If you're curious, a complete list of changes is available.

A summary of the current changes:

  • Added a "video volume" option for adjusting the starting volume of video posts.
  • Added a "disable tagged filenames" option to allow filename control for logged out users and manual (as needed) correction for logged in users.
  • Added a "video playback" blacklist option to allow control over the play/pause state of video posts.
  • Added a "hide hidden posts notice" option for hiding the Danbooru notice about hidden posts and gold accounts.
  • Added an "erase settings" section to the preferences tab for easily deleting BBB information.
  • Removed the "move save search" option since the save search button has been replaced by a link in the "+" search button.
  • Updated the "auto-hide sidebar" and "fixed sidebar" options to make them compatible with the "+" search button.
  • Updated to add back support for Danbooru's post to post hotkey navigation for searches while logged out.
  • Updated the methods for saving information so that settings can persist across all Danbooru domains and during private browsing.
  • Fixed various random search issues related to hidden posts.

@fireattack
Copy link
Author

Thanks, it did fix the bug!

@ghost
Copy link

ghost commented Apr 25, 2017

Version 7.3 will be out on Fork before too long so you can do an official upgrade then.

@ghost ghost closed this as completed Apr 25, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant