Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IBM Z missing #37

Closed
rdapp1 opened this issue Nov 7, 2017 · 3 comments
Closed

Support for IBM Z missing #37

rdapp1 opened this issue Nov 7, 2017 · 3 comments

Comments

@rdapp1
Copy link

rdapp1 commented Nov 7, 2017

When trying to run a benchmark I noticed that the function collect_cpu_freq() in _collect_metadata.py parses the output of /proc/cpuinfo but fails on the IBM Z (mainframe, S/390).

On Linux on IBM Z the output may look like this:

vendor_id       : IBM/S390
# processors    : 16
[...]
processor 0: version = 00,  identification = [...]
cpu number      : 0
cpu MHz dynamic : 5208
cpu MHz static  : 5208
[...]

The code splits lines starting with processor at ':' which will not yield a proper CPU number on Z. It should suffice, however, to check the vendor_id for IBM/S390 and look for cpu number in this case instead. The parsing of of the frequency should work ok with the existing logic.

@vstinner
Copy link
Member

vstinner commented Nov 7, 2017

Do you want to work on a patch?

@rdapp1
Copy link
Author

rdapp1 commented Nov 13, 2017

No idea why the email response to this thread did not go through, here it is again:

Unfortunately, it would take me a while to obtain copyright assignment
for a new project :( I already have a fix on my machine that is rather
trivial and works as far as I can tell, I just cannot post it here for
legal reasons. Therefore, I assume it will be faster if you fix it.

@vstinner
Copy link
Member

Fixed by commit 7febee0 which will be in the 1.6 release that I will release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants