Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nav Bar for Mobile - High Priority #36

Closed
meg-ray opened this issue May 16, 2021 · 4 comments
Closed

Fix Nav Bar for Mobile - High Priority #36

meg-ray opened this issue May 16, 2021 · 4 comments

Comments

@meg-ray
Copy link
Contributor

meg-ray commented May 16, 2021

On mobile the (iOS & Chrome browsers) the menu in the Nav Bar does not persistently display, making only the homepage viewable on mobile.

@lkuznia
Copy link
Collaborator

lkuznia commented May 16, 2021

I will take a look at this.

@lkuznia
Copy link
Collaborator

lkuznia commented May 16, 2021

There is a conflict in the collapse functionality between the bootstrap and figuration libraries. Spoke with @meg-ray and I will try to remove the usage of bootstrap in favor of figuration.

@birdcar birdcar added this to Proposed in Application Refactor May 19, 2021
@birdcar birdcar moved this from Proposed to To Do in Application Refactor May 19, 2021
@salticus
Copy link

salticus commented May 2, 2022

tl;dr @birdcar (are you the right one to ping?) I would suggest closing this issue since it seems to be fixed on the running website.

The commit message on f43701f, which is in the master branch, claims to have fixed this issue. On education.python.org the menus remain opened after tapping on the menu icon in the middle of the top bar on an iPhone 6s in both Safari and Chrome.

@birdcar
Copy link
Collaborator

birdcar commented Jun 14, 2022

@salticus thanks for the ping here, and sorry for missing it! I just dug myself out of a GitHub notifications hole. 🙇🏽

I don't know who the right person to ping here is, but I agree with you that this has been resolved. I have the ability to close this issue, so I'm going to go ahead and do it. Other maintainers can re-open if we discover that either you or I misunderstood the issue at play here and it wasn't fixed by f43701f

@birdcar birdcar closed this as completed Jun 14, 2022
Application Refactor automation moved this from To Do to Complete Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants