Enhance super_len to count encoded bytes for str
#6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two tests here. One demonstrating existing, correct behavior for `data=bytes`, and another, failing, test for the case where `data=string` and the string contains multi-byte UTF-8.
sigmavirus24
requested changes
Nov 29, 2023
This fixes issue psf#6586
bruceadams
force-pushed
the
super_len_str_utf-8
branch
from
0216ae7
to
3fd309a
Compare
|
@sigmavirus24 would you mind taking at these new changes? |
|
closing and re-opening to trigger a new build |
nateprewitt
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
I'll leave any final comments and merging to @sigmavirus24 but this looks reasonable to me. Thanks @bruceadams!
sigmavirus24
approved these changes
Feb 23, 2024
Merged
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for issue #6586.
I am not at all confident that this is an appropriate change for Requests. All of the unit tests pass locally for me (specifically
make ci).