Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotation first char not present on Windows with Psi+ webkit #617

Closed
StinGer-ShoGuN opened this issue Mar 24, 2021 · 8 comments
Closed

Quotation first char not present on Windows with Psi+ webkit #617

StinGer-ShoGuN opened this issue Mar 24, 2021 · 8 comments
Labels

Comments

@StinGer-ShoGuN
Copy link

StinGer-ShoGuN commented Mar 24, 2021

Lately, when quoting text from a MUC, <ctrl> + s or right click > Citation on selected text in the MUC window, the quoted text begins with while it used to begin with ».

Example

OS:
Windows 10 20H2, build 19042.867

Psi Version:
Psi+ v1.5.1477 (2021-01-02, af4b5b2, webengine)

XML log (you can find it in account's context menu)
Not relevent.

stdout (terminal log)
Here is an example, from Chromium debugger of a quoted text (not very helpful...).

<div class="msg">
    <img class="psi-icon" src="/psi/icon/psi/notification_chat_delivery_ok">
    <span style="color:#0044aa">[18:22:44] &lt;<a onclick="psiimtheme.addNick(this)" class="nicklink">StinGer</a>&gt;</span> <psims mid="pmrq"></psims><br>� [18:03:16] &lt;StinGer&gt; hst<br>
    <psime mid="pmrq"></psime>
</div>```
@tehnick
Copy link
Member

tehnick commented Mar 24, 2021

Try another font for group chat.

@StinGer-ShoGuN
Copy link
Author

We thought about that with @Ri0n but I can type or copy/paste » and even see them in the group chat.

@tehnick
Copy link
Member

tehnick commented Mar 24, 2021

Input field and chat history use different fonts.

@StinGer-ShoGuN
Copy link
Author

Sorry, I meant when I type and copy/paste », I then see it correctly in the chat history.

@Ri0n committed 32f95e7 as a possible fix. Our guess is it has to do with encoding conversion at some point. I'm not convinced the fix will work, but I'll try.

@StinGer-ShoGuN
Copy link
Author

I still have to test this. I have to setup everything to build Psi under Windows. I will. One day...

@Neustradamus
Copy link
Contributor

@tehnick
Copy link
Member

tehnick commented Apr 7, 2021

@StinGer-ShoGuN
Copy link
Author

Hey guys, sorry for the long delay.

The fix seems to be working. I tested it with the latest portable build for Windows, 1.5.1515 for x86_64 (anyone still using x86 ?!?), with both with and without WebKit. And it works, the » symbol is back there !

However, I realised the shortcut <Ctrl + S> was not working with the WebKit version... Go figure... Maybe I'll open another issue for this... one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants